Fix/making js work #1456
Merged
Fix/making js work #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wip: Getting async js feat: Have execute get action config feat: Read + Write chore: Add typing for globals chore: Change the default path, include error on missing function, and add json File Read Write chore: Change the default path, include error on missing function, and add json File Read Write wip: Fix the unit test wip: Fix the unit test feat: module loading
wip: Fix missing js files during running fix: Change the source + add input wip: Fix missing js files during running
Blu-J
force-pushed
the
fix/making-js-work
branch
2 times, most recently
from
5e9c3ff
to
7246cc0
Compare
Blu-J
commented
May 24, 2022
dr-bonez
requested changes
May 24, 2022
Blu-J
force-pushed
the
fix/making-js-work
branch
3 times, most recently
from
47eb702
to
39ae0e4
Compare
dr-bonez
previously approved these changes
May 24, 2022
backend/src/procedure/js_scripts.rs
Outdated
| } | ||
|
|
||
| /// Used during the subset, we are collapsing the state of the file paths. This will not work with soft link, | ||
| /// and the correct method, canonicalizePaths seems to freeze randomly, and is much slower. |
There was a problem hiding this comment.
This is concerning, we use canonicalize in several places. Evidence?
There was a problem hiding this comment.
Issue was that the freezing was the order of checking the error from javascript was wrong. Fixed, and made sure the is parent is safer, slower but safer.
There was a problem hiding this comment.
Move the canonicalize into the is_subset to remove the footguns.
Found an issue on the creation + canonicalize will always fail, which is why I have the parent for those two now. And added the tests for the symlink tests
dr-bonez
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Need to have end to end get/set config
properties
Proof
Showing it
Peek.2022-05-20.11-50.mp4
working
Example of throwing an error
