Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix "missing proxy" error in embassy-cli #1516

Merged
merged 2 commits into from Jun 10, 2022
Merged

fix "missing proxy" error in embassy-cli #1516

merged 2 commits into from Jun 10, 2022

Conversation

dr-bonez
Copy link
Member

@dr-bonez dr-bonez commented Jun 9, 2022

fixes #1511

@dr-bonez dr-bonez requested review from Blu-J and chrisguida June 9, 2022 06:56
@dr-bonez dr-bonez added Bug Something isn't working start-cli Issues pertaining to the CLI context of startd P0 - Blocks Dev This issue is mission critical to address imminently labels Jun 9, 2022
@dr-bonez dr-bonez added this to Code Review in EmbassyOS 0.3.1 via automation Jun 9, 2022
@dr-bonez dr-bonez added this to the 0.3.1 milestone Jun 9, 2022
Blu-J
Blu-J reviewed Jun 9, 2022
View reviewed changes
backend/src/context/cli.rs
@@ -39,6 +40,10 @@ pub struct CliContextSeed {
impl Drop for CliContextSeed {
fn drop(&mut self) {
let tmp = format!("{}.tmp", self.cookie_path.display());
let parent_dir = self.cookie_path.parent().unwrap_or(Path::new("/"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get this

Blu-J
Blu-J reviewed Jun 9, 2022
View reviewed changes
Copy link
Member

@Blu-J Blu-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1518 Has extra defaults that I found with a search and a test for the cli, would like to merge the answers.

@Blu-J Blu-J mentioned this pull request Jun 9, 2022
Closed
Blu-J
Blu-J requested changes Jun 9, 2022
View reviewed changes
Copy link
Member

@Blu-J Blu-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like the test that I wrote and there is one more default possible also that was in my pr

chrisguida
chrisguida previously approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@chrisguida chrisguida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works

@Blu-J Blu-J merged commit 435956a into master Jun 10, 2022
EmbassyOS 0.3.1 automation moved this from Code Review to Done Jun 10, 2022
@dr-bonez dr-bonez deleted the bugfix/cli-missing-proxy branch July 11, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blu-J Blu-J Blu-J approved these changes

@chrisguida chrisguida chrisguida left review comments

Assignees

@Blu-J Blu-J

@dr-bonez dr-bonez

Labels
Bug Something isn't working P0 - Blocks Dev This issue is mission critical to address imminently start-cli Issues pertaining to the CLI context of startd
Projects
No open projects
EmbassyOS 0.3.1
Done
Milestone
0.3.1
Development

Successfully merging this pull request may close these issues.

[bug]: [cli] No longer can login to embassy cli
3 participants
@dr-bonez @Blu-J @chrisguida