Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: HttpReader #1733

Merged
merged 14 commits into from
Aug 18, 2022
Merged

Feat: HttpReader #1733

merged 14 commits into from
Aug 18, 2022

Conversation

redragonx
Copy link
Contributor

No description provided.

@redragonx redragonx self-assigned this Aug 15, 2022
@redragonx redragonx linked an issue Aug 15, 2022 that may be closed by this pull request
[feat]: resumable downloads for s9pks #1644
Closed
@MattDHill MattDHill marked this pull request as draft August 15, 2022 18:09
dr-bonez
dr-bonez requested changes Aug 17, 2022
View reviewed changes
Copy link
Member

@dr-bonez dr-bonez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things here are not quite right. Also I would like you to throw errors for invalid seeks

backend/src/util/http_reader.rs Outdated Show resolved Hide resolved
backend/src/util/http_reader.rs Outdated Show resolved Hide resolved
backend/src/util/http_reader.rs Outdated Show resolved Hide resolved
backend/src/util/http_reader.rs Outdated Show resolved Hide resolved
backend/src/util/http_reader.rs Outdated Show resolved Hide resolved
dr-bonez
dr-bonez requested changes Aug 17, 2022
View reviewed changes
backend/src/util/http_reader.rs Show resolved Hide resolved
backend/src/util/http_reader.rs Show resolved Hide resolved
backend/src/util/http_reader.rs Outdated Show resolved Hide resolved
backend/src/util/http_reader.rs Outdated Show resolved Hide resolved
backend/src/util/http_reader.rs Outdated Show resolved Hide resolved
backend/src/util/http_reader.rs Outdated Show resolved Hide resolved
redragonx and others added 2 commits August 17, 2022 14:51
@redragonx @dr-bonez
Update backend/src/util/http_reader.rs
6c904a1 
Co-authored-by: Aiden McClelland <3732071+dr-bonez@users.noreply.github.com>
clean up work
3af35ca
dr-bonez
dr-bonez requested changes Aug 17, 2022
View reviewed changes
backend/src/util/http_reader.rs Outdated Show resolved Hide resolved
@dr-bonez dr-bonez marked this pull request as ready for review August 18, 2022 15:36
@dr-bonez dr-bonez changed the title Feat: Resumable downloads (WIP PR) Feat: HttpReader Aug 18, 2022
@dr-bonez dr-bonez merged commit 6505c40 into master Aug 18, 2022
@MattDHill MattDHill deleted the httpreader branch December 12, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-bonez dr-bonez dr-bonez approved these changes

Assignees

@redragonx redragonx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat]: resumable downloads for s9pks
2 participants
@redragonx @dr-bonez