[Fix] websocket connecting and patchDB connection monitoring #1738
Conversation
MattDHill
force-pushed
the
fix/connection-monitoring
branch
from
375ee14
to
ad037b1
Compare
frontend/projects/ui/src/app/app/global/services/patch-monitor.service.ts
Outdated
Show resolved
Hide resolved
| map(([connectionFailure, progress]) => { | ||
| if (connectionFailure === ConnectionFailure.None) { | ||
| return null | ||
| } else if (!!progress && progress.downloaded === progress.size) { |
There was a problem hiding this comment.
No need for else since there are return statements.
| @@ -31,7 +32,7 @@ export class MarketplaceListPage { | |||
| .pipe( | |||
| filter(data => exists(data) && !isEmptyObject(data)), | |||
| first(), | |||
| switchMapTo(this.marketplaceService.getPackages()), | |||
| switchMap(() => this.marketplaceService.getPackages()), | |||
There was a problem hiding this comment.
This could be the reason why now it requests packages upon reconnection — as opposed to switchMapTo now getPackages is getting called everytime stream gets here.
frontend/projects/ui/src/app/services/patch-db/patch-db.factory.ts
Outdated
Show resolved
Hide resolved
| .pipe( | ||
| debounceTime(420), | ||
| tap(cache => { | ||
| this.bootstrapper.update(cache) |
There was a problem hiding this comment.
The subscription is now here only to update the bootstrapper?
There was a problem hiding this comment.
I wonder if it makes sense to pass it to patch-db to be added here:
public cache$ = this.source$.pipe(
tap(res => this.store.update(res)),
map(_ => this.store.cache),
tap(cache => this.bootstrapper.update(cache),
shareReplay(1),
)Because we're not really starting anything here...
There was a problem hiding this comment.
I'm game, will require some thought as to keeping PatchDB generic with regard to initial cache and bootstrapper updating.
| @@ -1,4 +1,4 @@ | |||
| import { Component } from '@angular/core' | |||
| import { ChangeDetectionStrategy, Component } from '@angular/core' | |||
There was a problem hiding this comment.
Look like you forgot to use it
There was a problem hiding this comment.
No, I tested it and doesn't work on this page. Will remove the import
| // check for updates to EOS and services | ||
| this.checkForUpdates(ui) | ||
| // show eos welcome message | ||
| this.showEosWelcome(ui['ack-welcome']) |
There was a problem hiding this comment.
Seems like our next stop, after this is merged, is to switch this to a declarative modal.
| .pipe( | ||
| debounceTime(420), | ||
| tap(cache => { | ||
| this.bootstrapper.update(cache) |
There was a problem hiding this comment.
I wonder if it makes sense to pass it to patch-db to be added here:
public cache$ = this.source$.pipe(
tap(res => this.store.update(res)),
map(_ => this.store.cache),
tap(cache => this.bootstrapper.update(cache),
shareReplay(1),
)Because we're not really starting anything here...
No description provided.