use hostname from patchDB as default server name #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattDHill
force-pushed
the
feat/connection-message
branch
from
ec188ec
to
33d0a35
Compare
MattDHill
force-pushed
the
feat/connection-message
branch
from
a93b8f4
to
9e19348
Compare
elvece
reviewed
Aug 29, 2022
| const buffer = await blobToBuffer(this.toUpload.file!) | ||
| this.api.uploadPackage(guid, buffer).catch(e => console.error(e)) | ||
|
|
||
| this.navCtrl.navigateRoot('/services') |
There was a problem hiding this comment.
Why not navigate to the installing service?
|
Is it expected that nothing should display in the preferences page? |
elvece
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.