Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle multiple image tags having the same hash and increase timeout #1844

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

dr-bonez
Copy link
Member

No description provided.

@dr-bonez dr-bonez requested a review from Blu-J September 29, 2022 14:42
&& tag.ends_with(&format!(":{}", version))
})
.map(|tag| async {
let tag = tag; // move into future
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that the point of

move |tag| async{
}
//instead of 
|tag| async move {
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to move in ctx. Just tag

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point, thanks.

@dr-bonez dr-bonez merged commit 71b19e6 into master Sep 29, 2022
@MattDHill MattDHill deleted the bugfix/docker-image-removal branch December 12, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants