fix: Manager's exit not stopping #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About - Bad flow
We start with a running searxng.
Then we go and upgrade this service.
Issue: During the installation process we see it get stuck in the installation state.
About - Reason
The synchronizer is converting the service from killed -> sleep.
Also there is a state machine hell in this service.
Proof
Video showing that the
about - bad flowis no longer recreatable.Note: This still takes a long time since we are waiting for a timeout in the process of the searxng.
https://user-images.githubusercontent.com/2364004/211415883-675994cb-df72-4c97-a40a-89a63de8e158.mp4