Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/pwa #2246

Merged
merged 9 commits into from Apr 11, 2023
Merged

Feature/pwa #2246

merged 9 commits into from Apr 11, 2023

Conversation

elvece
Copy link
Member

@elvece elvece commented Mar 29, 2023

No description provided.

@elvece elvece requested a review from MattDHill March 29, 2023 17:55
@elvece elvece added this to the 0.4.0 milestone Mar 29, 2023
@elvece elvece added the UI Issues pertaining to any of the embassy-served web applications label Mar 29, 2023
@elvece elvece linked an issue Mar 29, 2023 that may be closed by this pull request
Add Web Manifest #60
Closed
elvece
elvece commented Mar 29, 2023
View reviewed changes
frontend/package-lock.json Outdated Show resolved Hide resolved
MattDHill
MattDHill previously approved these changes Mar 30, 2023
View reviewed changes
@elvece elvece linked an issue Mar 31, 2023 that may be closed by this pull request
Service Worker File Caching #61
Closed
2 tasks
@elvece elvece marked this pull request as draft March 31, 2023 16:54
@elvece elvece marked this pull request as ready for review April 4, 2023 23:29
@elvece elvece requested a review from waterplea April 4, 2023 23:29
@elvece
Copy link
Member Author

elvece commented Apr 4, 2023

@waterplea Since we have the RefreshAlertService, the user is prompted to refresh the page on any version mismatch between the FE and BE. From what I have researched and in testing, this refresh is sufficient for the service worker to update the cache. Any browser refresh or PWA reload works to get the new file versions.

Questions:

  1. Matt and I had discussed programmatically refreshing the cache within this service, but I do not think it is as safe or necessary. Let me know if you think otherwise.
  2. Do you recommend adding a service worker configuration for data groups, possibly for marketplace data?

@elvece elvece merged commit ba38057 into master Apr 11, 2023
12 checks passed
@elvece elvece deleted the feature/pwa branch May 12, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattDHill MattDHill MattDHill approved these changes

@waterplea waterplea Awaiting requested review from waterplea

Assignees
No one assigned
Labels
UI Issues pertaining to any of the embassy-served web applications
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

Service Worker File Caching Add Web Manifest
2 participants
@elvece @MattDHill