display icons based on mime type #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattDHill
previously approved these changes
May 12, 2023
dr-bonez
reviewed
May 12, 2023
Co-authored-by: Aiden McClelland <3732071+dr-bonez@users.noreply.github.com>
dr-bonez
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an MVP solution for displaying icons based on their mime type (file extension). It does not handle dependencies because a registry feature is needed to accommodate this. Dependencies are hard coded to use
.pngfiles, and this is fine because they all currently this type.Impetus: Needed for 0342 release so that new community services can use svg icons.