Add Connection class, to allow for non-global use. #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preserve global APIs 'setup', 'execute_query', etc., using a global instance of that class.
Allows passing the connection through explicitly, rather than relying on global or class defaults. This should allow for connection-pooling, as well as having different connections used in different parts of the application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve global APIs 'setup', 'execute_query', etc., using a global instance of that class.
'Vertex' and 'Element' subclasses can be assigned an instance via '_set_connection', or have one passed in the class suite as '_connection'; in either case the global instance will be ignored (and need not even be configured).
Making the classes independent of the connection would be even more flexible, but would involve moving all the class methods, as well as the instance construction, to the connection object.