Fix version file URL and KSP_VERSION_MIN #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version file has two problems:
URLproperty contained a link to a non-existent file, which means KSP-AVC won't be able to check for updatesKSP_VERSION_MINproperty was set to 1.99999.99999, which means this mod would only be considered compatible if the user had installed that version of KSP or later. There will probably never be such a version of KSP, so it's not compatible with anything. (This has blocked v1.2.0.1 from being indexed in CKAN.)This PR fixes these issues.
URLis set to the raw GitHub URL for this fileKSP_VERSION_MINis set to 1.8.0, to allow this mod to be considered compatible with that version of KSP and laterNote that a new release would be needed to make these fixes available to users.