Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digital Theme #57

Merged
merged 24 commits into from
Aug 24, 2020
Merged

Digital Theme #57

merged 24 commits into from
Aug 24, 2020

Conversation

M-A-Boucher
Copy link
Contributor

No description provided.

@M-A-Boucher
Copy link
Contributor Author

M-A-Boucher commented Aug 10, 2020

Left to do before merging into master:

  • - Rename the module, feature, and widgets. (I suggest WebpageCore for the module or something that represents essential/core elements to build a page.)
  • - Find common widgets across the Digital Theme and vLab theme and agree on style class names that can be reused across those themes and future themes

@jonlamdev
Copy link
Member

Document the module as well; see #55

@@ -0,0 +1,3 @@
</section>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should experiment with shape wrappers instead of having partial html tags in different files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had looked into this a few months ago and couldn't get the shape wrapper to work the way I want it to work.

@jptissot
Copy link
Contributor

jptissot commented Aug 11, 2020

When adding a new theme or module that has a package.json file, you need to modify the postinstall script in the root package.json file for it to install assets for it.

https://github.com/StatCan/StatCan.OrchardCore/blob/master/package.json#L18

@M-A-Boucher M-A-Boucher merged commit 222af60 into master Aug 24, 2020
@jonlamdev jonlamdev deleted the digitaltheme branch October 1, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants