-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Digital Theme #57
Digital Theme #57
Conversation
Left to do before merging into master:
|
Document the module as well; see #55 |
src/Modules/StatCan.OrchardCore.Widgets/StatCan.OrchardCore.Widgets.csproj
Outdated
Show resolved
Hide resolved
src/Modules/StatCan.OrchardCore.Widgets/Views/DigitalInnovationLogo.liquid
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,3 @@ | |||
</section> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should experiment with shape wrappers instead of having partial html tags in different files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had looked into this a few months ago and couldn't get the shape wrapper to work the way I want it to work.
When adding a new theme or module that has a https://github.com/StatCan/StatCan.OrchardCore/blob/master/package.json#L18 |
Authored-by: Brendan Bronzan
No description provided.