Hackathon module #59
Merged
Hackathon module #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # StatCan.OrchardCore.sln
jptissot
reviewed
Sep 29, 2020
src/Modules/StatCan.OrchardCore.Hackathon/Indexes/HackathonItemsIndex.cs
Show resolved
Hide resolved
src/Modules/StatCan.OrchardCore.Hackathon/MigrationExtensions.cs
Outdated
Show resolved
Hide resolved
src/Modules/StatCan.OrchardCore.Hackathon/MigrationExtensions.cs
Outdated
Show resolved
Hide resolved
|
|
||
| // keep a reference to the VeeValidate observer | ||
|
|
||
| Object.assign(this.$data, this.$options.data.apply(this)); // keep a reference to the VeeValidate observer |
There was a problem hiding this comment.
This should probably not be here 🤔
src/Themes/HackathonTheme/Views/Widget-TeamDashboardWidget.liquid
Outdated
Show resolved
Hide resolved
….OrchardCore into hackathon_module
|
Let's start testing / fixing this PR so it can be merged soon. Things todo:
|
….OrchardCore into hackathon_module
Also fixed an encoding issue for b64 encoding
….OrchardCore into hackathon_module # Conflicts: # test/cypress/integration/hackathon.js
jptissot
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hackathon module
Fix: #117