Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update references to daaas to aaw #1

Merged
merged 1 commit into from
May 17, 2023
Merged

update references to daaas to aaw #1

merged 1 commit into from
May 17, 2023

Conversation

bryanpaget
Copy link
Contributor

@bryanpaget bryanpaget commented May 10, 2023 •
edited
Loading

We may want to change the manifest but I'm not sure of the implications so I'll just leave it for now.

We could change daaas-system to aaw-system:

name: blob-csi-injector
namespace: daaas-system
- blob-csi-injector.daaas-system
- blob-csi-injector.daaas-system.svc
- blob-csi-injector.daaas-system.svc.cluster

@bryanpaget bryanpaget mentioned this pull request May 10, 2023
Closed
Souheil-Yazji
Souheil-Yazji approved these changes May 17, 2023
View reviewed changes
Copy link

@Souheil-Yazji Souheil-Yazji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the manifest and renaming daaas-system to aaw-system is a little complex because the ns would be recreated, can skip for now

@Souheil-Yazji Souheil-Yazji merged commit 8794b0c into main May 17, 2023
2 checks passed
@Souheil-Yazji Souheil-Yazji deleted the rename-references-to-daaas-to-aaw branch May 17, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Souheil-Yazji Souheil-Yazji Souheil-Yazji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bryanpaget @Souheil-Yazji