main-2.0: add new URL for SAS 9.4 M8 #634
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanpaget
changed the title
bryanpaget
changed the title
mathis-marcotte
requested changes
Jun 25, 2024
docker-bits/6_sas.Dockerfile
Outdated
| @@ -11,22 +11,39 @@ RUN wget -q ${QUARTO_URL} -O /tmp/quarto-${QUARTO_VERSION}-linux-amd64.tar.gz && | |||
| chmod +x /tmp/quarto-${QUARTO_VERSION} && \ | |||
| ln -s /tmp/quarto-${QUARTO_VERSION}/bin/quarto /usr/bin/quarto | |||
|
|
|||
| RUN groupadd -g 1002 sasstaff && \ | |||
| RUN groupadd -g 1337 supergroup && \ | |||
There was a problem hiding this comment.
This is reverting a PR I made. Is this actually necessary?
There was a problem hiding this comment.
It's just an old branch, I opened the branch before you made those changes, so this branch still had the old stuff. I've made the changes to match the work you did. Thank you for pointing that out. I should pay more attention when making pull requests for old branches.
There was a problem hiding this comment.
There was another user/permissions error:
Line 33:
chown -R sas:sasstaff /usr/local/SASHome --> chown -R jovyan:sasstaff /usr/local/SASHome
mathis-marcotte
requested changes
Jun 25, 2024
mathis-marcotte
requested changes
Jun 26, 2024
mathis-marcotte
requested changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update is to remove the SAS image's dependency on sas4c, which is the older SAS image using SAS 9.4 M7.
I have uploaded SAS 9.4 M8 to an Azure storage container and moved the relevant logic out of sas4c into the AAW SAS image.
Todo:
Ticket: https://jirab.statcan.ca/browse/BTIS-304