Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rstudio to jupyterlab image #642

Merged
merged 6 commits into from
Jun 25, 2024

Conversation

bryanpaget
Copy link
Contributor

@bryanpaget bryanpaget commented Jun 24, 2024

adding rstudio to jupyterlab just like in the sas image
ticket: https://jirab.statcan.ca/browse/BTIS-377

@bryanpaget bryanpaget added the auto-deploy Trigger manual CI steps for this PR label Jun 24, 2024
Copy link
Contributor

@mathis-marcotte mathis-marcotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on artifactory.cloud.statcan.ca/das-aaw-docker/jupyterlab-cpu:596c2fed85f12fa3b086538ef7748c941134f368

This is making it so when you open the notebook, it automatically sets you in Rstudios, as if you were running an Rstudio image in AAW. Maybe when I suggested to change the ordering in the make file, it messed that up?

Copy link
Contributor

@mathis-marcotte mathis-marcotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the remaining workflows are green, LGTM.

Tested on artifactory.cloud.statcan.ca/das-aaw-docker/jupyterlab-cpu:69e69f68880fadf6d2372b22d529b7964e90c207

Rstudio icon was in the jupyter launcher, and it worked.

@Souheil-Yazji Souheil-Yazji merged commit 35d7e02 into master-2.0 Jun 25, 2024
7 checks passed
@Souheil-Yazji Souheil-Yazji deleted the bryan-add-rstudio-to-jupyter branch June 25, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-deploy Trigger manual CI steps for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants