Skip to content

Commit

Permalink
Need to set storageClassName of the persistent volume used with cloud…
Browse files Browse the repository at this point in the history
… filestore. (kubeflow#3268)

Related to: kubeflow#2475

Update kf_is_ready_test to print out the namespace we are monitoring
for the deployments; makes it easier to debug issues like kubeflow#3273 that was
causing test failures.
  • Loading branch information
jlewi authored and k8s-ci-robot committed May 17, 2019
1 parent 4e56a20 commit d1d163e
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
1 change: 1 addition & 0 deletions kubeflow/gcp/google-cloud-filestore-pv.libsonnet
Expand Up @@ -21,6 +21,7 @@
path: params.path,
server: params.serverIP,
},
storageClassName: "nfs-storage",
},
},
persistentVolume:: persistentVolume,
Expand Down
1 change: 1 addition & 0 deletions kubeflow/gcp/tests/google-cloud-filestore-pv_test.jsonnet
Expand Up @@ -35,6 +35,7 @@ local testCases = [
path: "/kubeflow",
server: "10.10.10.10",
},
storageClassName: "nfs-storage",
},
},
},
Expand Down
11 changes: 7 additions & 4 deletions testing/kfctl/kf_is_ready_test.py
Expand Up @@ -60,16 +60,19 @@ def test_kf_is_ready(namespace, use_basic_auth, use_istio):

# TODO(jlewi): Might want to parallelize this.
for deployment_name in deployment_names:
logging.info("Verifying that deployment %s started...", deployment_name)
logging.info("Verifying that deployment %s.%s started...",
namespace, deployment_name)
util.wait_for_deployment(api_client, namespace, deployment_name)

ingress_namespace = "istio-system" if use_istio else namespace
for deployment_name in ingress_related_deployments:
logging.info("Verifying that deployment %s started...", deployment_name)
logging.info("Verifying that deployment %s.%s started...",
ingress_namespace, deployment_name)
util.wait_for_deployment(api_client, ingress_namespace, deployment_name)

for name in stateful_sets:
logging.info("Verifying that statefulset %s started...", name)
logging.info("Verifying that statefulset %s.%s started...",
ingress_namespace,name)
util.wait_for_statefulset(api_client, ingress_namespace, name)

# TODO(jlewi): We should verify that the ingress is created and healthy.
Expand Down

0 comments on commit d1d163e

Please sign in to comment.