Add reasonable default to tf-serving s3 creds (kubeflow#1304)

Most of people will use env name as key in secret, might as well make it default
StatCan · Aug 2, 2018 · d464031 · d464031
1 parent 1baadcd
commit d464031
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/kubeflow/tf-serving/tf-serving.libsonnet b/kubeflow/tf-serving/tf-serving.libsonnet
@@ -52,10 +52,10 @@
     //  Name of the k8s secrets containing S3 credentials
     s3SecretName: "",
     // Name of the key in the k8s secret containing AWS_ACCESS_KEY_ID.
-    s3SecretAccesskeyidKeyName: "",
+    s3SecretAccesskeyidKeyName: "AWS_ACCESS_KEY_ID",
 
     // Name of the key in the k8s secret containing AWS_SECRET_ACCESS_KEY.
-    s3SecretSecretaccesskeyKeyName: "",
+    s3SecretSecretaccesskeyKeyName: "AWS_SECRET_ACCESS_KEY",
 
     // S3 region
     s3AwsRegion: "us-west-1",