Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove namespace #151

Closed
wants to merge 2 commits into from
Closed

Remove namespace #151

wants to merge 2 commits into from

Conversation

wg102
Copy link

@wg102 wg102 commented Aug 22, 2023 •
edited
Loading

@wg102 wg102 added the auto-deploy Trigger manual CI steps for this CI label Aug 22, 2023
@wg102 wg102 force-pushed the feat-remove-all-namespaces branch from 4c9bc84 to 2b519f6 Compare August 24, 2023 19:30
mathis-marcotte
mathis-marcotte requested changes Aug 25, 2023
View reviewed changes
Copy link

@mathis-marcotte mathis-marcotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The option wasn't removed from the correct place, you edited the files under crud-web-apps/common, which is not a part of the repo that we actually use. You need to look under centraldashboard component

@wg102
Copy link
Author

wg102 commented Aug 30, 2023

Closing the branch since many update on the stc-master. And this code doesn't change anything

@wg102 wg102 closed this Aug 30, 2023
@wg102 wg102 deleted the feat-remove-all-namespaces branch August 30, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathis-marcotte mathis-marcotte mathis-marcotte requested changes

Assignees
No one assigned
Labels
auto-deploy Trigger manual CI steps for this CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wg102 @mathis-marcotte