Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error catching for s3-pull batch insert #2250

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add error catching for s3-pull batch insert #2250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fd7b02
Add catch
crayolakat Dec 13, 2022
99aee7f
Change console.log to console.error
crayolakat Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/extensions/contact-loaders/s3-pull/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,9 @@ export async function loadContactS3PullProcessFile(jobEvent, contextVars) {
return { alreadyComplete: 1 };
}

await r.knex.batchInsert("campaign_contact", insertRows);
await r.knex.batchInsert("campaign_contact", insertRows).catch(e => {
console.error("Error with S3 pull batch insertion for campaign", campaign_id, e);
});
}

if (fileIndex < manifestData.entries.length - 1) {
Expand Down