-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulk Send Batch Progress UI #2305
Open
codygordon
wants to merge
3
commits into
main
Choose a base branch
from
bulk-send-progress-ui
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codygordon
commented
Oct 9, 2023
package.json
Outdated
@@ -232,5 +232,8 @@ | |||
"react-tooltip": "^4.2.13", | |||
"recompose": "^0.30.0", | |||
"webpack-cli": "^4.7.2" | |||
}, | |||
"browser": { | |||
"crypto": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: removed this because it was fixed a different way in another PR; confirmed that other fix works for me locally.
crayolakat
previously approved these changes
Oct 9, 2023
crayolakat
approved these changes
Oct 27, 2023
crayolakat
added
the
S-ready for stage-main (qa)
Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc
label
Dec 8, 2023
Closed
crayolakat
added
S-testing-on-stage
Status (ADMINS ONLY): PR label for presence on a staging instance
and removed
S-ready for stage-main (qa)
Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc
labels
Dec 8, 2023
Closed
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces bulk send batch console logs with a progress UI as well as error handling in the client.
I also went ahead and just completely refactored this component to be functional w/ hooks. I figure it's probably best to write any new components this way if we can as this is the current standard way of creating doing things with React, and in this case it was pretty straightforward to convert it to be fully component-state-based and replace the while loop with a
useEffect
hook.If there's an error it will show it as a snackbar alert for 6 seconds if not clicked off, then end sending and reset to be able to show the button again. I still can't figure out how to bubble up actual error messages to the client, and the docs for the old Apollo express package we're using are now offline. That's is something else to note: Apollo packages should be updated soon as we are on a version that is EOL as of this month.
Also noting, we might want to start adding some custom ESLint overrides as we have so many errors/warnings in the codebase they just get ignored. I added our first override in this PR to allow any
console
output exceptlog
, the reasoning being it's sometimes desirable to leave permanent logs in withinfo
,warn
, orerror
, and with this setting it allows those but you can still get warnings if you have a temporary debugginglog
in there that you actually want to remove, so you don't forget to do that, and any permanent non-error/warning logging can useinfo
.Anyway, here are a couple screenshots showing how this UI implementation looks:
Checklist: