Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: glitch for {filters,groups}_default #1082

Closed
wants to merge 1 commit into from

Conversation

oliverpool
Copy link
Contributor

@oliverpool oliverpool commented Feb 8, 2024

I just noticed a glitch when using groups_default:

  • visit the demo site
  • look the Posts page: the default group should be selected
  • switch to FAQ
  • switch back to Posts: the default group is not selected anymore

I tried to fiddle with the code, but my knwoledge there is far too limited (I only saw that React was loading the CollectionView more than 100 times...)

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for demo-staticjscms ready!

Name Link
🔨 Latest commit 16706d5
🔍 Latest deploy log https://app.netlify.com/sites/demo-staticjscms/deploys/65c4ae00d182280009e9dc7d
😎 Deploy Preview https://deploy-preview-1082.demo.staticcms.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for staticjscms ready!

Name Link
🔨 Latest commit 16706d5
🔍 Latest deploy log https://app.netlify.com/sites/staticjscms/deploys/65c4ae004334f20008dc0019
😎 Deploy Preview https://deploy-preview-1082.staticcms.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ccd242c) 55.87% compared to head (16706d5) 55.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1082   +/-   ##
=======================================
  Coverage   55.87%   55.87%           
=======================================
  Files         259      259           
  Lines       12318    12318           
  Branches     3090     3090           
=======================================
  Hits         6883     6883           
  Misses       5028     5028           
  Partials      407      407           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KaneFreeman
Copy link
Collaborator

I've got a fix for this issue in #1083

@KaneFreeman KaneFreeman closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants