Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow events to be registered without collection specified #972

Merged
merged 2 commits into from Nov 7, 2023

Conversation

KaneFreeman
Copy link
Collaborator

@KaneFreeman KaneFreeman commented Nov 7, 2023

Allow event handlers for change, preSave, postSave, prePublish and postPublish events to be registered without a collection specified (or even a field for change).

Addresses #970

Copy link

netlify bot commented Nov 7, 2023

Deploy Preview for demo-staticjscms ready!

Name Link
🔨 Latest commit b71a002
🔍 Latest deploy log https://app.netlify.com/sites/demo-staticjscms/deploys/654a716c0caf340008fdbb9d
😎 Deploy Preview https://deploy-preview-972.demo.staticcms.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 7, 2023

Deploy Preview for staticjscms ready!

Name Link
🔨 Latest commit b71a002
🔍 Latest deploy log https://app.netlify.com/sites/staticjscms/deploys/654a716cb894fa00085219fc
😎 Deploy Preview https://deploy-preview-972.staticcms.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #972 (b71a002) into next (6354675) will increase coverage by 1.45%.
The diff coverage is 90.44%.

@@            Coverage Diff             @@
##             next     #972      +/-   ##
==========================================
+ Coverage   54.27%   55.73%   +1.45%     
==========================================
  Files         258      258              
  Lines       12169    12226      +57     
  Branches     3068     3072       +4     
==========================================
+ Hits         6605     6814     +209     
+ Misses       5128     5004     -124     
+ Partials      436      408      -28     
Files Coverage Δ
packages/core/src/interface.ts 87.50% <ø> (ø)
packages/core/src/lib/registry.ts 71.62% <90.44%> (+54.95%) ⬆️

@KaneFreeman KaneFreeman merged commit d10e754 into next Nov 7, 2023
18 checks passed
@KaneFreeman KaneFreeman deleted the fix/loosen-event-handler-requirements branch November 7, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant