Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: absolute media urls leading slash being trimmed #981

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

KaneFreeman
Copy link
Collaborator

No description provided.

Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for staticjscms ready!

Name Link
🔨 Latest commit 478cec4
🔍 Latest deploy log https://app.netlify.com/sites/staticjscms/deploys/654d05c2d4345800084e8734
😎 Deploy Preview https://deploy-preview-981.staticcms.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for demo-staticjscms ready!

Name Link
🔨 Latest commit 478cec4
🔍 Latest deploy log https://app.netlify.com/sites/demo-staticjscms/deploys/654d05c286acce0008bda9bb
😎 Deploy Preview https://deploy-preview-981.demo.staticcms.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@KaneFreeman KaneFreeman changed the title fix absolute media urls leading slash being trimmed fix: absolute media urls leading slash being trimmed Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #981 (478cec4) into next (48e1e40) will decrease coverage by 0.01%.
Report is 1 commits behind head on next.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             next     #981      +/-   ##
==========================================
- Coverage   55.75%   55.75%   -0.01%     
==========================================
  Files         258      258              
  Lines       12275    12274       -1     
  Branches     3081     3081              
==========================================
- Hits         6844     6843       -1     
  Misses       5026     5026              
  Partials      405      405              
Files Coverage Δ
packages/core/src/lib/util/media.util.ts 46.34% <33.33%> (-0.44%) ⬇️

@KaneFreeman KaneFreeman merged commit 55b0ffa into next Nov 9, 2023
17 of 19 checks passed
@KaneFreeman KaneFreeman deleted the fix/absolute-media-issue branch November 9, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant