Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only add public folder if path matches media folder #991

Merged
merged 2 commits into from Nov 30, 2023

Conversation

KaneFreeman
Copy link
Collaborator

Fixes #985

Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for staticjscms ready!

Name Link
🔨 Latest commit a364fb9
🔍 Latest deploy log https://app.netlify.com/sites/staticjscms/deploys/6557ad11f364ef00078dd5bd
😎 Deploy Preview https://deploy-preview-991.staticcms.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for demo-staticjscms ready!

Name Link
🔨 Latest commit a364fb9
🔍 Latest deploy log https://app.netlify.com/sites/demo-staticjscms/deploys/6557ad11d300e00009b61761
😎 Deploy Preview https://deploy-preview-991.demo.staticcms.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0c0803b) 52.28% compared to head (a364fb9) 52.29%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #991      +/-   ##
==========================================
+ Coverage   52.28%   52.29%   +0.01%     
==========================================
  Files         231      231              
  Lines        9889     9893       +4     
  Branches     2587     2590       +3     
==========================================
+ Hits         5170     5174       +4     
  Misses       4334     4334              
  Partials      385      385              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KaneFreeman KaneFreeman merged commit dd80bfa into main Nov 30, 2023
17 checks passed
@KaneFreeman KaneFreeman deleted the fix/relative-choose-url branch November 30, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to insert relative or root-relative links
1 participant