Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/upgrade carousel component to embla carousel #150

Conversation

shuvo-me
Copy link
Contributor

@shuvo-me shuvo-me commented Mar 16, 2024

Copy link

vercel bot commented Mar 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep-react ❌ Failed (Inspect) Apr 15, 2024 11:39am

Copy link

vercel bot commented Mar 16, 2024

@shuvo-me is attempting to deploy a commit to the StaticMania Team on Vercel.

A member of the Team first needs to authorize it.

@Arifulislam5577
Copy link
Collaborator

Dear @shuvo-me,

Your work is very good. You are to be commended for that. But we want to give you some guidelines how to make your work more beautiful and comfortable.

We will use the embla-carousel library for the carousel component.
First we will create a wrapper on top of the embla carousel. From where the items of the carousel can be controlled. And the carousel will look exactly like the embla carousel examples.

For example:

  • Default Style
  • Loop
  • Slides To Scroll
  • Drag Free
  • ClassNames
  • Parallax
  • Scale
  • Lazy Load

You can put numbers in the carousel item, or use the pictures we have provided. It is completely up to you. Only the carousel should look like an instance of the embla carousel.

I hope you understand. Best of luck.

Thank you
Md Ariful Islam

@shuvo-me
Copy link
Contributor Author

Dear @shuvo-me,

Your work is very good. You are to be commended for that. But we want to give you some guidelines how to make your work more beautiful and comfortable.

We will use the embla-carousel library for the carousel component. First we will create a wrapper on top of the embla carousel. From where the items of the carousel can be controlled. And the carousel will look exactly like the embla carousel examples.

For example:

  • Default Style
  • Loop
  • Slides To Scroll
  • Drag Free
  • ClassNames
  • Parallax
  • Scale
  • Lazy Load

You can put numbers in the carousel item, or use the pictures we have provided. It is completely up to you. Only the carousel should look like an instance of the embla carousel.

I hope you understand. Best of luck.

Thank you Md Ariful Islam

@Arifulislam5577 Thanks vai for your suggestions. I will update the features as well.

Copy link
Collaborator

@Arifulislam5577 Arifulislam5577 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this small issue. You are doing really well. After fixed this issue then I will merge your code in our main branch. Thank you.

app/docs/components/carousel/variant/Autoplay.tsx Outdated Show resolved Hide resolved
app/docs/components/carousel/variant/Autoplay.tsx Outdated Show resolved Hide resolved
app/docs/components/carousel/variant/ClassNames.tsx Outdated Show resolved Hide resolved
app/docs/components/carousel/variant/DefaultCarousel.tsx Outdated Show resolved Hide resolved
app/docs/components/carousel/variant/DefaultCarousel.tsx Outdated Show resolved Hide resolved
app/docs/components/carousel/variant/DefaultCarousel.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants