Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SSC to latest version #2

Merged
merged 4 commits into from Sep 29, 2020
Merged

Update SSC to latest version #2

merged 4 commits into from Sep 29, 2020

Conversation

jerluc
Copy link
Member

@jerluc jerluc commented Sep 28, 2020

This includes various changes to support building libssc from it's latest release tag (2020.2.29_Release), which had some additional fallout associated:

  • Split up into separate download, build, and install scripts in order to allow arbitrary code patching post-download but pre-build; this also makes it a little easier to debug
  • Created two separate Docker builds: Alpine Linux and Ubuntu; this has helped me debug various build failures due to difference in environments (namely glibc vs. musl-libc)
  • Created a patched nlopt/timer.c file to account for time.h/sys/time.h differences between glibc and musl-libc
  • Updated build script to produce an optimized build output via CMake (in earlier versions of SSC, we had used simple Makefiles)

This also splits out the build into both an Alpine and Ubuntu image with separate builds, including
some distro-specific patches
@ccma14
Copy link
Contributor

ccma14 commented Sep 29, 2020

This includes various changes to support building libssc from it's latest release tag (2020.2.29_Release), which had some additional fallout associated:

  • Split up into separate download, build, and install scripts in order to allow arbitrary code patching post-download but pre-build; this also makes it a little easier to debug
  • Created two separate Docker builds: Alpine Linux and Ubuntu; this has helped me debug various build failures due to difference in environments (namely glibc vs. musl-libc)
  • Created a patched nlopt/timer.c file to account for time.h/sys/time.h differences between glibc and musl-libc
  • Updated build script to produce an optimized build output via CMake (in earlier versions of SSC, we had used simple Makefiles)

@jerluc I pushed a change onto the branch that does not require a patched version of timer.c. In a nutshell, the nlopt code snapshot that is checked into ssc contains its own copies of sys/time.h and since a cmake build adds an explicit include directive pointing to the original source location (due to an out-of-tree build process), we pick up those during the build process rather than the system-provided ones.

IMHO these include files should not be checked into nlopt to begin with...

@jerluc jerluc merged commit 7d977c9 into master Sep 29, 2020
@jerluc jerluc deleted the update-ssc branch September 29, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants