-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module name #1
Comments
Agree. I thought it would make sense to just have I have changed the module so that from version 1.0.1 you can do Also in the README NOTE: having some issues to put v1.0.1 on PyPi
seems like I did it before while I was testing stuff and had by mistake boost up my version and PyPI doesn't seem to allow uploading versions that have been previously removed. Unless you have a suggestion here I suggest to wait until we have v1.1.0 (going to add some new operators soon anyways) and then upload that to PyPI. |
Waiting for |
I assume you wanted to say
|
Aaah yep, I fixed it in the comment above :) otherwise that would be much of a change ;) |
Indeed 😄 Closing it then, thanks! |
I suggest to change the module name from
lops
topylops
, to be the same as the package name to install.I installed it with
pip install pylops
, fired-up an IPython session, and runimport pylops
just to get an error thatpylops
is apparently not installed. So you have to go to the documentation and examples to find out how to call it. Ah, it's name islops
, soimport lops
.I might not be the only one facing that issue. Most modules follow the convention to name the module the same as the package you install (e.g.
numpy
,scipy
,numba
,matplotlib
, basically most I can think of, although there are exceptions).I thought I open an issue to discuss it and change it now (
v1.0.1
) or never, as the package is still pretty new and not too much code is written yet withimport lops
. This will probably change pretty soon and changing the module name would not be a good idea anymore down the road.The text was updated successfully, but these errors were encountered: