-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit username #34
Comments
The aim was also to make this as simple as possible. In the best case, out of the box, but users still have to define some variables.
So you edited commit_username="" to something like I have just tested it, and it works for me without any problems. First, I just had it as [user@klipper klipper-backup]$ whoami
user Then I adjusted the Just test this again and follow this. Step by step. If you're 100% sure this is not the problem, please provide the following information/output: cd ~/config_backup
git config user.name whoami
cat ~/klipper-backup/.env |
Yes, I tried difference names in the defined section there, ran script in terminal, ran it in main sail. Edited some files to make sure it was pushing new ones. Everything shows the commits by that name and i wasnt sure why. First i left that empty and expected to see pi as the user. |
Now I'm quite confused. Is this one of your GitHub profiles? Maybe Mahallon is in your global git config? Can you please run |
I found that profile as well but no its not mine. I created my github last year and only used for backups, I made a new repo when attempting to follow your guide. So my understanding appears to be right and we both do not know how it displays that name. It does not appear to be an issue within the pi itself at this point. pi@raspberrypi: |
It seems to be an issue with your system and not klipper-backup itself. In your Please edit the @Tylerjet just made a short test with this email. Your problem seems to be related with this article: https://docs.github.com/en/enterprise-cloud@latest/pull-requests/committing-changes-to-your-project/troubleshooting-commits/why-are-my-commits-linked-to-the-wrong-user# Basically this one GitHub profile is using pi@raspberry so every time you try to push a commit with his email he will appears in your commit history. So we just overwrite this global git setting. |
Thanks for the help, I did some searching but didn't come across that. That was the default I suppose from the raspberry pi OS image. Everything looks good now! Might be worth noting for the rookies to fill in the optional commit username/email |
Yeah we just chatted about it the plan is to make it use a more unique string (probably the commit hash of the most recent commit) instead of just using the hostname. That way the email is unique unless set specifically in .env. |
Problem is now fix'd with latest commit to prevent issues like this. |
Let me start by saying that I have very little github experience but many of us are just using our klipperized 3d printers and want a nice backup solution so we are using this.
Currently the latest update on 1/12 fixed my issue that i had where it wouldn't backup at all. I received
fatal: could not read password for 'https://ghp_xxxxxxxxxxx@github.com' : no such device or address and would not work at all.
Now the backup works fine with the newest update but all the commits show Mahallon as the user.
I attempted to edit the comit username in the .env file but nothing seems to change.
The text was updated successfully, but these errors were encountered: