Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of sequential algorithm for kNN #1

Merged
merged 7 commits into from
Dec 11, 2020
Merged

Implementation of sequential algorithm for kNN #1

merged 7 commits into from
Dec 11, 2020

Conversation

Stavrosfil
Copy link
Owner

@Stavrosfil Stavrosfil commented Dec 10, 2020 •
edited
Loading

  • Implement kNN
  • Implement k-select

@georgegito
Copy link
Collaborator

georgegito commented Dec 11, 2020 •
edited
Loading

Need to fix the case that X and Y have some common points. In that case, y should reject adding itself to its kNN.

@georgegito georgegito mentioned this pull request Dec 11, 2020
Closed
@Stavrosfil Stavrosfil linked an issue Dec 11, 2020 that may be closed by this pull request
Self-adding to kNN rejection #2
Closed
@Stavrosfil Stavrosfil removed a link to an issue Dec 11, 2020
Self-adding to kNN rejection #2
Closed
@Stavrosfil
Copy link
Owner Author

This closes #2

@Stavrosfil Stavrosfil merged commit 0480388 into master Dec 11, 2020
@georgegito georgegito added v1 v0 and removed v1 labels Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Stavrosfil Stavrosfil

@georgegito georgegito

Labels
sequential v0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Stavrosfil @georgegito