Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with NC>24 #54

Open
StCyr opened this issue Aug 16, 2023 · 2 comments
Open

Compatibility with NC>24 #54

StCyr opened this issue Aug 16, 2023 · 2 comments

Comments

@StCyr
Copy link

StCyr commented Aug 16, 2023

With NC26 (maybe 25 too), you need the following patch to get the app working (in addition to the 'max-version' field in info.xml ofc):

diff --git a/lib/Db/Property.php b/lib/Db/Property.php
index 2bf8d3e..8326eb4 100644
--- a/lib/Db/Property.php
+++ b/lib/Db/Property.php
@@ -14,6 +14,8 @@ class Property extends Entity
     public $propertyname;
     /** @var string */
     public $propertyvalue;
+    /** @var int */
+    public $valuetype;
 
     public function __construct()
     {
@@ -22,5 +24,6 @@ class Property extends Entity
         $this->addType('propertypath', 'string');
         $this->addType('propertyname', 'string');
         $this->addType('propertyvalue', 'string');
+        $this->addType('valuetype', 'int');
     }
-}
\ No newline at end of file
+}
@WilliamFromTW
Copy link

works like a charm(NC 25)

@vjku
Copy link

vjku commented Feb 23, 2024

works on NC 28 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants