This repository has been archived by the owner on Aug 10, 2022. It is now read-only.
Fix ws conns bookkeeping #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll try to test it later if I have time (unless you already have?). If it works, I'll increment version for this, I think it's important. |
|
I tested it in the sense that I could open a second instance of /live and the first one still continues receiving new messages. However I noticed that both would eventually stop updating and I haven't had the time to figure out how long that typically takes and why. I'll look into it today. |
|
Noticed The disconnect issue doesn't happen locally, so it's most likely due to my host (trying out nitrous.io) timing out the websocket. Trying pingTimer next. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #18