Option Display SteamDb Rating #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GayKevin
commented
Nov 7, 2017
GayKevin
commented
- Add option to display SteamDb Rating on app pages
xPaw
reviewed
Nov 7, 2017
scripts/store/app.js
Outdated
| } | ||
|
|
||
| if( items[ 'link-steamdb-rating' ] ) | ||
| { |
There was a problem hiding this comment.
It should be fix now
There was a problem hiding this comment.
Converted all spaces to tabs
xPaw
reviewed
Nov 7, 2017
scripts/store/app.js
Outdated
|
|
||
| if( element ) | ||
|
|
||
| // We need to bind a tooltip, and the only way to do that is to inject a script into the page |
There was a problem hiding this comment.
Sorry, i deleted the duplicate code.
xPaw
reviewed
Nov 7, 2017
options/options.html
Outdated
| @@ -64,6 +64,11 @@ | |||
| <span class="control-indicator"></span> | |||
| Add a calculator link on community profiles | |||
| </label> | |||
| <label class="control checkbox"> | |||
| <input type="checkbox" class="option-check" checked data-option="link-steamdb-rating"> | |||
There was a problem hiding this comment.
- Changed to
steamdb-rating
|
It's still using spaces, not tabs. |
- Add option to display SteamDb Rating on app pages
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.