Skip to content
This repository has been archived by the owner on Jul 4, 2018. It is now read-only.

Fix xpaw's horrible formatting #243

Closed
wants to merge 3 commits into from
Closed

Conversation

rannmann
Copy link

No description provided.

@dragonfire535
Copy link

While I don't like the style myself, the way this PR is done is rather immature, and stating one's style is better than others is not very polite nor accurate, styles are subjective, so what looks yucky to you or me may be beautiful to someone else.

Just my two cents.

@Byter09
Copy link

Byter09 commented Jun 30, 2018

You could've searched in closed PRs. I already submitted a PR regarding PSR-2. It was closed in minutes... :P

@AgentOak
Copy link

While I agree that the code style is atrocious, making a PR just replacing the lead developers' preferred style might be somewhat arrogant.

@Byter09
Copy link

Byter09 commented Jun 30, 2018

@Marco01809
I agree for such a project. But PSR-2 is simply a standard and basically every IDE has a feature to automatically format this way. So that's no excuse :)

@JourneyOver
Copy link
Contributor

But PSR-2 is simply a standard and basically every IDE has a feature to automatically format this way

Doesn't mean that people have to follow that standard if they don't want to. Believe it or not people are free to follow or not follow whatever standard they want.

@NoXPhasma
Copy link

The maintainer of a project has the right to chose the coding style. If you don't like to provide code this way, you are free to get along.

If you wanted to start a discussion about a change of the code style, you started it the complete wrong way.

@ALEEF02
Copy link
Contributor

ALEEF02 commented Jun 30, 2018

@rannmann It's not going to be pulled, might aswell close it now

@Scrxtchy
Copy link

image
image

@mat8913
Copy link

mat8913 commented Jun 30, 2018

Who cares? It's not like anyone's gonna look at this after the event ends.

Besides, if xpaw wanted good looking code, he wouldn't have made it in php.

@xPaw xPaw closed this Jun 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
10 participants