Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cef console button to developer settings #441

Merged
merged 6 commits into from
Jun 1, 2023
Merged

add cef console button to developer settings #441

merged 6 commits into from
Jun 1, 2023

Conversation

KP2048
Copy link
Contributor

@KP2048 KP2048 commented May 4, 2023

No description provided.

@KP2048
Copy link
Contributor Author

KP2048 commented May 4, 2023

oop my ide did a bad job with the commit username lol

@PartyWumpus
Copy link
Member

PartyWumpus commented May 4, 2023 •
edited

Works well, although it would probably be more convenient if it went directly to the SharedJSContext page, as no other pages would actually be useful as far as i can tell.
From the python side, a way of getting a link directly there would be (await get_tab('SharedJSContext')).id (which returns a value along the lines of E88A4C68268596E8826CB5C08DA8F5FE).
Then in ts, run NavigateToExternalWeb("localhost:8080/devtools/inspector.html?ws=localhost:8080/devtools/page/"+id)
I did find tab.ws_url, but it returns ws://localho... not ws=localho...

Okay I'm just going to try do this myself at this point. If it fails then I guess it can fall back to localhost:8080.

Clip of it working just to be sure:

2023-05-04.17-37-21.mp4

@KP2048
Copy link
Contributor Author

KP2048 commented May 4, 2023

Oh neat, a pr to a pr? Lol

@PartyWumpus
Copy link
Member

I guess so lol. Can't edit this directly so I'll make a PR.

@KP2048
Copy link
Contributor Author

KP2048 commented May 4, 2023

yea having it directly open the console would be preferable

@KP2048
Copy link
Contributor Author

KP2048 commented May 4, 2023 •
edited

also need italian translations for the new ui elements, but probably let the guy that did the i18n stuff do that as i believe he made the ones for the rest of the ui if i remember correctly. (i don't know italian)

@PartyWumpus
Copy link
Member

I feel a little stupid right now, but your repo is protected so I can't directly edit it (unlike most PRs), and I can't make a fork of your fork without deleting my existing one (which I can't do). I guess I could make a fork under the steamdeckhomebrew team, but that seems silly.

@KP2048
Copy link
Contributor Author

KP2048 commented May 4, 2023

i can give you write access if you want

@KP2048
Copy link
Contributor Author

KP2048 commented May 4, 2023

wait would this fix?
Disable branch protection rules

@PartyWumpus
Copy link
Member

Yeah that would probably work, sounds good.

@KP2048
Copy link
Contributor Author

KP2048 commented May 4, 2023

ok try now

@KP2048
Copy link
Contributor Author

KP2048 commented May 4, 2023

here i just added you to the repo so you can just push to it lol

@KP2048
Copy link
Contributor Author

KP2048 commented May 4, 2023

nice

@PartyWumpus
Copy link
Member

Hopefully someone else has the time to test this, because I don't know if I can test my own code lol.
I'll still give it a test once it's finished building though.

@KP2048
Copy link
Contributor Author

KP2048 commented May 4, 2023

works great for me

@KP2048 KP2048 closed this May 4, 2023
@PartyWumpus
Copy link
Member

did you just accidentally overwrite your fork?

@PartyWumpus PartyWumpus reopened this May 4, 2023
@KP2048 KP2048 force-pushed the main branch 2 times, most recently from fa49b98 to 8ac0177 Compare May 4, 2023 18:50
@PartyWumpus
Copy link
Member

It's working well on my PC and my deck

2023-05-04.19-38-46.mp4

@KP2048 KP2048 force-pushed the main branch 2 times, most recently from 0786418 to 8ac0177 Compare May 4, 2023 19:02
KP2048 and others added 4 commits May 4, 2023 15:06
@KP2048
add cef console button
035574b
@RodoMa92 @KP2048
Small fix: handle missing localization in backend plus a small typo i…
409a592 
…n the english language (SteamDeckHomebrew#443)

* Hotfix for i18n where the detector was overriding localStorage

* Please, pnpm, cooperate

* Small fix regarding the backend getting hammered when switching to not supported languages plus a small english typo
@PartyWumpus @KP2048
Add a get_tab_id function to utilities
0ff142b
@PartyWumpus @KP2048
Go straight to SharedJSContext into console button
51e020f
@TrainDoctor TrainDoctor added the enhancement New feature or request label May 31, 2023
@TrainDoctor TrainDoctor requested review from a team May 31, 2023 13:35
JohnnyCrazy
JohnnyCrazy requested changes May 31, 2023
View reviewed changes
Copy link
Member

@JohnnyCrazy JohnnyCrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 small things, otherwise LGTM

frontend/src/components/settings/pages/developer/index.tsx Outdated Show resolved Hide resolved
frontend/src/components/settings/pages/developer/index.tsx Outdated Show resolved Hide resolved
TrainDoctor
TrainDoctor approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my deck, works good. Once Johnny approves this will be good for merge.

@PartyWumpus PartyWumpus merged commit f4c0a8b into SteamDeckHomebrew:main Jun 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnnyCrazy JohnnyCrazy JohnnyCrazy approved these changes

@TrainDoctor TrainDoctor TrainDoctor approved these changes

Assignees

@KP2048 KP2048

Labels
enhancement New feature or request
Projects
SDH Tracker
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@KP2048 @PartyWumpus @JohnnyCrazy @TrainDoctor @RodoMa92