Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TabsHook #458

Merged
merged 13 commits into from
May 31, 2023
Merged

Refactor TabsHook #458

merged 13 commits into from
May 31, 2023

Conversation

Maclay74
Copy link
Contributor

@Maclay74 Maclay74 commented May 17, 2023

This merge request presents alternative way to extract qAMroot.

Before merge we need this PR to be merged first.

frontend/src/tabs-hook.tsx Outdated Show resolved Hide resolved
frontend/src/tabs-hook.tsx Outdated Show resolved Hide resolved
frontend/src/tabs-hook.tsx Outdated Show resolved Hide resolved
frontend/src/tabs-hook.tsx Outdated Show resolved Hide resolved
frontend/src/tabs-hook.tsx Outdated Show resolved Hide resolved
Mikhail Kozlov added 2 commits May 17, 2023 11:33
frontend/src/tabs-hook.tsx Outdated Show resolved Hide resolved
@Maclay74 Maclay74 changed the title Refactor TabsHook Draft: Refactor TabsHook May 18, 2023
@TrainDoctor TrainDoctor added the enhancement New feature or request label May 18, 2023
@Maclay74 Maclay74 changed the title Draft: Refactor TabsHook Refactor TabsHook May 19, 2023
@TrainDoctor
Copy link
Member

@Maclay74 please upgrade the version of DFL used in this PR so CI can build it.

Bump DFL version
@TrainDoctor
Copy link
Member

CI is not working please fix the lockfile and attempt to build locally to make sure everything works.

@Maclay74
Copy link
Contributor Author

Sure, I just tried from the phone, forgot about the lock.

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all changes to package.json and pnpm-lock.yaml. Once this is done it should be good to merge.

@Maclay74
Copy link
Contributor Author

Done. I removed all the changes, including DFL version bump

@TrainDoctor
Copy link
Member

@Maclay74 the person who instructed me to ask you to revert the DFL bump was mistaken, please update DFL only for now. Sorry about that.

@TrainDoctor TrainDoctor merged commit b27b625 into SteamDeckHomebrew:main May 31, 2023
4 checks passed
AAGaming00 added a commit that referenced this pull request Jun 3, 2023
This reverts commit b27b625.

These changes broke Decky's QAM injection when the lock screen is enabled and need to be revised
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants