Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to hide plugins from quick access menu #468

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

JohnnyCrazy
Copy link
Member

@JohnnyCrazy JohnnyCrazy commented May 28, 2023

Please tick as appropriate:

  • I have tested this code on a steam deck or on a PC
  • My changes generate no new errors/warnings
  • This is a bugfix/hotfix
  • This is a new feature

If you're wanting to update a translation or add a new one, please use the weblate page: https://weblate.werwolv.net/projects/decky/

Description

This fixes issue: #317

TODO:

  • Add a way to synchronize settings across useSettings calls
  • On uninstall of a plugin, also remove it from the settings key.

Screenshots

image
image
image

@JohnnyCrazy JohnnyCrazy self-assigned this May 28, 2023
@JohnnyCrazy JohnnyCrazy marked this pull request as draft May 28, 2023 23:48
@JohnnyCrazy JohnnyCrazy added the enhancement New feature or request label May 28, 2023
@JohnnyCrazy JohnnyCrazy force-pushed the hide-plugins-from-qa branch 3 times, most recently from 58aa3e3 to ea5cd7c Compare May 29, 2023 16:56
@JohnnyCrazy
Copy link
Member Author

Alright, this PR should be ready. Some notes:

  • I freestyled the UI, so feel free to make suggestions. While the text Hidden from quick access menu is quite long, I didn't just want to put the icon as it feels like it's not descriptive enough on it's own.
  • On uninstall, the hidden setting for this plugin is reset. i.e. if you install it again, it will always be visible first.

In the long-term, we should investigate some time to making adding such settings-based features easier. With websockets, we might be able to make a nice two-way sync, for example.

@JohnnyCrazy JohnnyCrazy marked this pull request as ready for review May 29, 2023 17:34
@JohnnyCrazy JohnnyCrazy requested a review from a team May 29, 2023 17:35
@JohnnyCrazy
Copy link
Member Author

@SteamDeckHomebrew/decky-testers

@TrainDoctor TrainDoctor requested a review from a team May 29, 2023 17:36
@TrainDoctor TrainDoctor merged commit 47bc910 into main Jun 7, 2023
10 checks passed
@TrainDoctor TrainDoctor deleted the hide-plugins-from-qa branch June 7, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants