Ignore chmod if decky is not run as root #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueldr
reviewed
Jul 21, 2023
backend/localplatformlinux.py
Outdated
| @@ -60,6 +60,8 @@ def chown(path : str, user : UserType = UserType.HOST_USER, recursive : bool = | |||
| return result == 0 | |||
|
|
|||
| def chmod(path : str, permissions : int, recursive : bool = True) -> bool: | |||
| if os.geteuid != 0: | |||
There was a problem hiding this comment.
You probably also want to log a warning for future support issues, allowing the project support peeps to understand that it's not running as root, I'd assume.
E.g. [WARNING] decky-loader running as unprivileged user $username.
There was a problem hiding this comment.
Probably best to just show this once on startup, but yes that is a good idea, will do
There was a problem hiding this comment.
Sure, I'm about 0% familiar with the codebase, the overall important thing is to ensure you all in support position can identify the situation, now that it can happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please tick as appropriate:
If you're wanting to update a translation or add a new one, please use the weblate page: https://weblate.werwolv.net/projects/decky/
Description
This fixes the issue issue mentioned here Jovian-Experiments/Jovian-NixOS#111 and here #446 (comment)
While decky doesn't really support running as the user, as it breaks some of its features, we might as well make it functional where possible. This has not been tested, i'll test it in a moment and then merge it myself, so I don't really know who I'm writing this for or why I'm making it a PR instead of just commiting to main...