Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Decky-Recorder 0.0.4 #243

Merged
merged 7 commits into from
Feb 19, 2023
Merged

Conversation

marissa999
Copy link
Contributor

@marissa999 marissa999 commented Feb 19, 2023

Decky Recorder

Version 0.0.4

  • Changed the picture in the plugin.json
  • Added the option to output .mp4, .mkv and mov
  • Added a lot of useless methods that currently do not do anything

This plugin allows the user to start and stop a recording of the screen + audio of the Steam Deck. This plugin is heavily based on the recapture-plugin for Crankshaft.

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
    Note: I do use the original gst-launcher-1.0 from SteamOS (which I call through Python), but I am downloading extra dependencies in a Holo-Base--Docker-Container and use those additional libraries as part of the gst-launcher-1.0-command
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable Update Channel.
  • Tested on SteamOS Beta Update Channel.

@marissa999 marissa999 requested a review from a team as a code owner February 19, 2023 20:21
@marissa999 marissa999 temporarily deployed to testing_env February 19, 2023 20:21 — with GitHub Actions Inactive
@TrainDoctor TrainDoctor requested a review from a team February 19, 2023 21:28
@TrainDoctor
Copy link
Member

Good is good, sending to testing.

Copy link

@DJScias DJScias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decky: 2.5.4-pre1
SteamOS: 3.4.4 Stable, Beta and Preview

A) No major issues noticed.

B) One minor issue noticed.
When you open the menu you can see it very quickly change from MP4 to MKV or QuickTime. Which means its respecting the option you chose correctly but it seems to always try MP4 as a split second default. Not sure if that's a decky limitation or if the split-second MP4 switch is a minor default switch bug. It's minor, but just something you catch when you open/close the menu a lot.

However on restart of the steam deck it seems it doesn't save yet which option you use. As it defaulted back to MP4. It's minor though, as I also can't say whether persistence on output is meant to be respected through restarts just yet.

C) Yay for production. All seems in order truly.

Tested 3 times (MP4, MKV, QuickTime) on each channel thus 9 files in total. Just like the last time. There is one or two videos 2/9 that are a bit choppier than the rest. But the other ones are snappy. I can't reliably seem to make them go bad/good, but in about 80-90% of all cases the videos seem to be fine and it could also just be quickly menu switching about.

@TrainDoctor TrainDoctor merged commit d0374a5 into SteamDeckHomebrew:main Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants