Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Free Loader to 1.2.0 #513

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Update Free Loader to 1.2.0 #513

merged 1 commit into from
Mar 17, 2024

Conversation

jwhitlow45
Copy link
Contributor

@jwhitlow45 jwhitlow45 commented Jan 12, 2024

FreeLoader

  • Add support for free games from GOG
    • Add settings toggle for GOG store
  • Individual games can now be hidden in the games list
    • Add settings toggle for showing hidden games in games list
  • Add settings toggle for showing game titles in games list
  • Fixed UI bug where last game in games list was hidden by footer
  • Modified game filter to be less restrictive

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.

@TrainDoctor
Copy link
Member

Good to go for testing.

@safijari
Copy link
Contributor

safijari commented Mar 7, 2024

Tested it. Seems to be working as expected. I would argue that it should keep notifying with some cadence about X free games until the user has viewed them once. As it stands the first notification says N new games found, and subsequent notifications say 0 new games found.

@jwhitlow45
Copy link
Contributor Author

Great point. I'm busy with work this week but I'll do my best to make that change this weekend.

@TrainDoctor
Copy link
Member

@jwhitlow45 would you like me to merge this now or to wait until you have made the changes that were suggested? I would expect the suggested changes to be tested as well.

@jwhitlow45
Copy link
Contributor Author

I've been pretty busy so go ahead and merge it and I'll do a minor update when I have time to address the comment. Thanks.

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testers approve, off to production.

@TrainDoctor TrainDoctor merged commit 0f5ce7c into SteamDeckHomebrew:main Mar 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants