Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isthereanydeal-for-deck v1.0.0 #605

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

JtdeGraaf
Copy link
Contributor

@JtdeGraaf JtdeGraaf commented Apr 18, 2024

IsThereAnyDeal for Deck

A Decky plugin for Steam Deck that shows IsThereAnyDeal data on the Deck's game store pages.

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.
  • Tested on SteamOS Preview Update Channel.

Copy link
Contributor

@RodoMa92 RodoMa92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, good to go to testing.

@RodoMa92
Copy link
Contributor

RodoMa92 commented Apr 19, 2024

Works great, thanks! Couple of improvements:

  1. If a game is free to play, instead of showing it by default I would just disable showing it up (not sure how you would behave for a temporary free to keep titles, tho. Not sure if Steam JS API has a parameter to check for free to play titles built in).

  2. Maybe leave an optional manual setup of the API key for IsThereAnyDeals, otherwise i can see your key to be just rate limited or completely disabled by them.

Still, good job! Would love for something more comprehensive like https://augmentedsteam.com/ but I know how much pain is patching Steam's UI code, so I'm fine even only with this.

@RodoMa92 RodoMa92 merged commit 35dfbfe into SteamDeckHomebrew:main Apr 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants