Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Custom icons #19

Closed
ghost opened this issue Jun 22, 2017 · 18 comments
Closed

[Enhancement] Custom icons #19

ghost opened this issue Jun 22, 2017 · 18 comments
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Jun 22, 2017

Examples:
2017-06-22_16-45-58
2017-06-22_16-45-58e

@HEspoke
Copy link
Collaborator

HEspoke commented Jun 25, 2017

First of all, I love the original post pictures. Its basically the games that I have been playing recently haha. Could @ThePiranhaPlant explain a little bit to me what the request is? It looks like you already have SRM looking for Local Images for your roms, so what would be the need for "custom icons"?
Thanks

Edit: Now that I have been using the program for a little bit I think I know what @ThePiranhaPlant needs. I will address it in my next post on this thread

@HEspoke
Copy link
Collaborator

HEspoke commented Jun 26, 2017

I have a large amount of Steam Grid images that I pulled from a program called Streamgrid . I used that program to fill in the gaps for my Big Picture Mode images when ICE found all that it could from consolegrid (RIP). Could @FrogTheFrog please consider the following feature that would help with the custom icon problem that @ThePiranhaPlant mentioned and help the program A LOT in the future.
What we need is a option on the left on the program named "Global Settings" (or something like that). The global setting section would help with configuring settings across all emulator. One of the settings would be Local Images. This local images setting would pull from a user defined folder and fill in the "Preview" option with your own local images when you are going to parse all of your emulators. It would integrate your local images when you are "generating your app" list. This way you can set your local images folder one time for all of your steam grid images for all games instead of doing it on a single emulator basis. Once @FrogTheFrog integrates this "Global Settings" option (if its possible) on the left side of the GUI he can add more options withing that setting in future updates.

@FrogTheFrog FrogTheFrog added this to the 2.1.0 release milestone Jun 26, 2017
@HEspoke
Copy link
Collaborator

HEspoke commented Jun 29, 2017

Addition: Having all of the Steamgrid image sources listed with toggle switches next to them. This way the user can turn off or on these sources before going through the Parsing process and creating the "App List". This would be especially useful for users that have a large library of ROMs.
Example:
X Retrogaming.cloud
X Consolegrid.com
X Steamgriddb.com
X Local Images

@UndarkAido
Copy link
Contributor

https://github.com/Hafas/nostegama has this feature, and I'd really love to see it here.

@FrogTheFrog
Copy link
Contributor

@ThePiranhaPlant, @HEspoke, @Aidoboy What should be displayed when SRM can't show the icon itself (unsupported format for SRM, but not for Steam... maybe)? Also should the icon's size remain fixed or should it scale with the grid image? Finally, what should be the max/fixed size for icon?

@UndarkAido
Copy link
Contributor

Default icon should be the exe icon.

From this article
"Icons: These are standard icons, you’ll need either a .exe with an embedded icon (like the .exe of the app itself, if it has an icon you want) or the icon you want to use as a .PNG or .TGA file that’s square (e.g. 256 x 256 pixels) like a regular icon file." (Or it should be an ICO file)

@FrogTheFrog
Copy link
Contributor

FrogTheFrog commented Aug 12, 2017

That's not what I meant. Anyway, it does not matter now. This is how it will look like when the icon is found and I can display, and when it's found, but I can't display it:

image

or

image

Which one is better? I should also mention, that SRM won't be able to display icons that are embedded in .exe. To achieve that, I would need to use Windows API, .Net or just write my own code to parse .exe in binary format. First two "solutions" would not allow SRM to be run on linux and the third one is a pain in the ass to write from scratch. If someone would write it, I would gladly implement it.

@FrogTheFrog
Copy link
Contributor

Needless to say, you will be able to select from multiple icons if you wish. For example, first one would be the real one and another one could be a fallback if the first one does not exist.

@HEspoke
Copy link
Collaborator

HEspoke commented Aug 12, 2017

@FrogTheFrog The second image is the one I would go with. This one = https://user-images.githubusercontent.com/22381748/29243396-bdd9a626-7fa6-11e7-9111-6da46a711ea0.png

I am not quite sure what @Aidoboy is talking about. As it currently stands, the Stand View of Steam already previews the EXE file embedded image by default. For my emulators, the EXE is shown for all my emulators and that already happens in Steam vanilla.

One question for you @FrogTheFrog , if SRM cant find the EXE image and it shows the eye with the line through it, will SRM populate that eye image in all the EXE images for Steam Standard View?

@FrogTheFrog
Copy link
Contributor

FrogTheFrog commented Aug 13, 2017

@HEspoke SRM can't display EXE image, however it does not mean that Steam can't. The eye will be shown only in SRM. I don't really care what you choose as an image, I'll just pass IT along into Steam configuration and then Steam will have to deal with it.

@HEspoke
Copy link
Collaborator

HEspoke commented Aug 13, 2017 via email

@UndarkAido
Copy link
Contributor

@FrogTheFrog
Copy link
Contributor

@Aidoboy No, because it is a "wrapper around a .net executable". This will break compatibility with linux.

@UndarkAido
Copy link
Contributor

@FrogTheFrog Can't you just not load it on mac/linux?

@FrogTheFrog
Copy link
Contributor

@Aidoboy Hmm... I will try something.

@FrogTheFrog
Copy link
Contributor

@Aidoboy It seems that .NET can now be compiled for linux too, however icon extractor uses Windows specific code, which will not work on linux. As for the question whether I could just load it on Windows - yes, I believe I could. However, I really don't want to separate code into "Windows and others"...

@UndarkAido
Copy link
Contributor

UndarkAido commented Aug 13, 2017 via email

@FrogTheFrog
Copy link
Contributor

@Aidoboy So far it's pain in the ass. NET code seems to compile, but there are problems with paths and the fact that icon extractor uses one event emitter without ability to pass a function callback to it. I will keep it as a very low priority and will eventually try to adapt it to this app. For now I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants