Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Undo on delete #39

Closed
ChibiChoko opened this issue Aug 13, 2017 · 4 comments
Closed

[Enhancement] Undo on delete #39

ChibiChoko opened this issue Aug 13, 2017 · 4 comments

Comments

@ChibiChoko
Copy link
Contributor

After accidentally deleting a parser I had set up, I think it would be swell to add an undo button after deleting a parser. Just in case.

@FrogTheFrog
Copy link
Contributor

FrogTheFrog commented Aug 14, 2017

What about just a modal window asking you to confirm your action? For all red buttons.

@ChibiChoko
Copy link
Contributor Author

That's an option, though I believe someone in Discord earlier provided a strong reasoning for an undo button rather than a confirmation prompt.

https://alistapart.com/article/neveruseawarning

@HEspoke
Copy link
Collaborator

HEspoke commented Aug 14, 2017

I tested the fix that you made concerning the Auto Saving when Testing Parser. It has a undesirable outcome unfortunately. If a user edits the parser and then presses Test Parser before pressing Save then the user looses all the changes that he made to Test Parser. What I was hoping would happen is that a user could use the Test Parser button as a simulation ground when creating Parser configs. But what happens is that if the user presses Test Parser then he looses all changes made to the parser if he didnt first press Save.
If you cant work out a way to make Test Parser keep the changes in the parser but not permanently save them until the user presses Save then you should revert SRM back to its previous state and make Test Parser save when the Test Parser button is pressed.

@HEspoke
Copy link
Collaborator

HEspoke commented Aug 23, 2017

@FrogTheFrog Great job on getting the Test Parser functionality working in a way that allows the user to do a test config on their parser. I like it

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants