Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency upgrade request: rustix #228

Closed
timf opened this issue Apr 8, 2023 · 2 comments · Fixed by #229
Closed

Dependency upgrade request: rustix #228

timf opened this issue Apr 8, 2023 · 2 comments · Fixed by #229

Comments

@timf
Copy link

timf commented Apr 8, 2023

Could you require rustix 0.37.11 or higher in the next tempfile release? This includes a fix for a build issue that was causing constant recompilation (evading the benefits of Rust's incremental compilation).

I tested the change locally, and both my tests and tempfile tests passed on rustc 1.68.2 on Linux and OSX (sorry, I do not have quick access to a Windows environment).

Thank you!

@sunfishcode
Copy link
Contributor

0.37.11 is semver-compatible with 0.37.1 which is the version tempfile references, so you should be able to update to rustix 0.37.11 and get the same effect by running this command:

cargo update --package=rustix

@timf
Copy link
Author

timf commented Apr 8, 2023

Thanks. I'd tried cargo update first, but it was not bumping it high enough. I just messed with it more, and this command worked:

cargo update --package=rustix --precise 0.37.11

Stebalien added a commit that referenced this issue Apr 8, 2023
Reduces compile times. Technically, downstream users can do this
themselves, but they likely won't know what's going on. This saves them
the trouble.

fixes #228
Stebalien added a commit that referenced this issue Apr 8, 2023
Reduces compile times. Technically, downstream users can do this
themselves, but they likely won't know what's going on. This saves them
the trouble.

fixes #228
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants