-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subpage UI changes #50
Conversation
child: FastTextField( | ||
maxLines: 5, | ||
name: "description_text_field", | ||
labelText: "Description", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make description labelText smaller? It's so jarring 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not able to make the reminder text in the box itself smaller with this widget.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah that's lowkey worse, let's keep what you had.
Also can you add to after line 26 of list_page.dart: |
Did not test adding markers to map, however it looks functional and connected to backend. Small nitpicks and improvements above, but looking great and good work @tbeidlershenk! |
Added comments and a few follow ups but once that's in there we can merge and have a new revamped UI. 👏 |
child: FastTextField( | ||
maxLines: 5, | ||
name: "description_text_field", | ||
labelText: "Description", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah that's lowkey worse, let's keep what you had.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed + Satisfied!
* Updated PostCard UI * Updated PostCard UI * Finished PostPage UI * Updated PostCard UI * Updated PostCard UI * Finished PostPage UI * Made item_request changes * Rebuiltsubmission page UI * Added back button & other small fixes * Small changes from PR review * Small UI tweaks
Changes
ListPage
PostPage
when a user clicks on a map item or page in the list viewItemRequest
and renamed toSubmissionPage
Notes
Can you let me know if you like the updated pages?
@jeffzheng13 when we merge PRs from now on can we choose "Squash and merge" so our commit history on main is more condensed?
and also we should get in the habit of rebasing our branches on main before submitting PRs. it removes the possibility of merge conflict