Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subpage UI changes #50

Merged
merged 14 commits into from
Jan 6, 2024
Merged

Subpage UI changes #50

merged 14 commits into from
Jan 6, 2024

Conversation

tbeidlershenk
Copy link
Collaborator

@tbeidlershenk tbeidlershenk commented Jan 3, 2024

Changes

  1. Rebuilt the UI of posts in ListPage
  2. Rebuilt the UI of PostPage when a user clicks on a map item or page in the list view
  3. Rebuilt the UI of ItemRequest and renamed to SubmissionPage

Notes

Can you let me know if you like the updated pages?
@jeffzheng13 when we merge PRs from now on can we choose "Squash and merge" so our commit history on main is more condensed?
and also we should get in the habit of rebasing our branches on main before submitting PRs. it removes the possibility of merge conflict

child: FastTextField(
maxLines: 5,
name: "description_text_field",
labelText: "Description",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make description labelText smaller? It's so jarring 😅

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Is this preferable?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to make the reminder text in the box itself smaller with this widget.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah that's lowkey worse, let's keep what you had.

@jeffzheng13
Copy link
Collaborator

Also can you add to after line 26 of list_page.dart:
objects.sort((a, b) => b.timeCreated.compareTo(a.timeCreated));
so the items are sorted by most recent date first.

@jeffzheng13
Copy link
Collaborator

Did not test adding markers to map, however it looks functional and connected to backend. Small nitpicks and improvements above, but looking great and good work @tbeidlershenk!

@jeffzheng13 jeffzheng13 mentioned this pull request Jan 4, 2024
3 tasks
@jeffzheng13 jeffzheng13 linked an issue Jan 4, 2024 that may be closed by this pull request
@jeffzheng13
Copy link
Collaborator

Added comments and a few follow ups but once that's in there we can merge and have a new revamped UI. 👏

lib/pages/post_page.dart Outdated Show resolved Hide resolved
lib/pages/post_page.dart Show resolved Hide resolved
child: FastTextField(
maxLines: 5,
name: "description_text_field",
labelText: "Description",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah that's lowkey worse, let's keep what you had.

lib/pages/submission_page.dart Outdated Show resolved Hide resolved
lib/pages/post_page.dart Show resolved Hide resolved
Copy link
Collaborator

@jeffzheng13 jeffzheng13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed + Satisfied!

@jeffzheng13 jeffzheng13 merged commit d7ce479 into main Jan 6, 2024
1 check passed
jeffzheng13 pushed a commit that referenced this pull request Jan 6, 2024
* Updated PostCard UI

* Updated PostCard UI

* Finished PostPage UI

* Updated PostCard UI

* Updated PostCard UI

* Finished PostPage UI

* Made item_request changes

* Rebuiltsubmission page UI

* Added back button & other small fixes

* Small changes from PR review

* Small UI tweaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remake subpage UIs: ItemRequest, PostPage
2 participants