contracts: early check that the fee is correct.

[dbadoy]

dixel-v2-contract/contracts/DixelClubV2Factory.sol

Lines 73 to 89 in a919f9a

	// Validate `symbol`, `name` and `description` to ensure generateJSON() creates a valid JSON
	if(!StringUtils.validJSONValue(name)) revert DixelClubV2Factory__NameContainedMalicious();
	if(!StringUtils.validJSONValue(symbol)) revert DixelClubV2Factory__SymbolContainedMalicious();
	if(!StringUtils.validJSONValue(description)) revert DixelClubV2Factory__DescriptionContainedMalicious();
	// Neutralize minting starts date
	if (metaData.mintingBeginsFrom < block.timestamp) {
	metaData.mintingBeginsFrom = uint40(block.timestamp);
	}
	if (creationFee > 0) {
	if(msg.value != creationFee) revert DixelClubV2Factory__InvalidCreationFee();
	// Send fee to the beneficiary
	(bool sent, ) = beneficiary.call{ value: creationFee }("");
	require(sent, "CREATION_FEE_TRANSFER_FAILED");
	}

dixel-v2-contract/contracts/lib/StringUtils.sol

Lines 12 to 27 in a919f9a

	function validJSONValue(string calldata haystack) internal pure returns (bool) {
	bytes memory haystackBytes = bytes(haystack);
	uint256 length = haystackBytes.length;
	for (uint256 i; i != length;) {
	bytes1 char = haystackBytes[i];
	if (char < 0x20 || char == 0x22 || char == 0x5c || char == 0x7f) {
	return false;
	}
	unchecked {
	++i;
	}
	}
	return true;
	}

I think validJSONValue() is pretty heavy method. ㅡespecially in check the description
So, It would be nice that early check the creation fee before validJSONValue().

[dbadoy]

Additional) To express the flow, this logic seems good.

if(msg.value != creationFee) revert DixelClubV2Factory__InvalidCreationFee();

// Validate `symbol`, `name` and `description` to ensure generateJSON() creates a valid JSON
if(!StringUtils.validJSONValue(name)) revert DixelClubV2Factory__NameContainedMalicious();
if(!StringUtils.validJSONValue(symbol)) revert DixelClubV2Factory__SymbolContainedMalicious();
if(!StringUtils.validJSONValue(description)) revert DixelClubV2Factory__DescriptionContainedMalicious();

// Neutralize minting starts date
if (metaData.mintingBeginsFrom < block.timestamp) {
    metaData.mintingBeginsFrom = uint40(block.timestamp);
}

if(creationFee > 0) {
    (bool sent, ) = beneficiary.call{ value: creationFee }("");
    require(sent, "CREATION_FEE_TRANSFER_FAILED");
}

[sydneyitguy]

LGTM 👍🏻