Cleanup #21
Merged
Cleanup #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* You shouldn't use `is` to check for string equality. * type(x) is str is an antipattern
* Extract common code in conditionals to before or after the conditional * Use more dictionary update logic
|
Thank you this a very good refactor, I will work on the issue with the sampling tonight before merging, I'm just finishing some polish on a paper. |
- Line lengths - Redundant parentheses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some significant cleanups. I'm doing a pull request so that you know about this and don't get tripped up on the merge. I've tried to be quite explicit in the commit messages, so have a look at them.