Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes #77

Merged
merged 12 commits into from Oct 8, 2023
Merged

Various fixes #77

merged 12 commits into from Oct 8, 2023

Conversation

Cl00e9ment
Copy link

Fixed

@Cl00e9ment
Copy link
Author

I think there is a nicer way to handle completion percentage:

  • Don't allow it to decrease, because it feels weird.
  • Cap it to (parts_downloaded+1) / total_parts

I'll change that later this day.

@Cl00e9ment
Copy link
Author

OK I think it's good now ahah

@StefanLobbenmeier
Copy link
Owner

Ok I will review when I get to it, hopefully this weekend 😄

@StefanLobbenmeier StefanLobbenmeier merged commit 3ec0052 into StefanLobbenmeier:master Oct 8, 2023
@StefanLobbenmeier
Copy link
Owner

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Cl00e9ment @StefanLobbenmeier