Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small additions #81

Merged

Conversation

AnessZurba
Copy link

These are minor changes I had in my fork.

I noticed today that this fork is active, so I'm rebasing my changes on top of it
I deleted all my fixes as I think you already did all of them more correctly (ytl-dlp download paths and progress reporting etc..)

Two changes appear in this PR

adding option for hibernate when done (On windows)
and the second is to focus the input field on startup. I think it's a reasonable behavior

@AnessZurba
Copy link
Author

I have to say I didn't test this (I'm not very proficient in js let alone its frameworks). Think of it as a feature request with sample code :)

@AnessZurba
Copy link
Author

but it did work in my old fork

@StefanLobbenmeier
Copy link
Owner

Sounds good 😄

In the windows start menu there is sometimes only one of the options (sleep hibernate), not sure if it might lead to confusion if this app shows all options.

Or in other words did you check what happens when hibernation is disabled / do we need to worry about error handling here?

@StefanLobbenmeier StefanLobbenmeier merged commit 3f25288 into StefanLobbenmeier:master Oct 8, 2023
@AnessZurba
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants