Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider switching all matrix code to neomatrix_config.h so that it works on all 2D backends #2

Open
marcmerlin opened this issue May 9, 2023 · 2 comments
Open

Consider switching all matrix code to neomatrix_config.h so that it works on all 2D backends #2

marcmerlin opened this issue May 9, 2023 · 2 comments

Comments

@marcmerlin
Copy link

Also, code like https://gist.githubusercontent.com/StefanPetrick/9c091d9a28a902af5a7b540e40442c64/raw/f9304216ffe96545584655ff4bfe3d26972b4d73/basic_render_engine_v01
should define all functions before they are used in the code.
I know the arduino compiler lets you get away with not doing that, but it fails with other regular compilers.
I will submit a patch to your code modified to fix both things mentioned here, and you can use it to convert your other code if you are interested
marcmerlin added a commit to marcmerlin/FastLED_NeoMatrix_SmartMatrix_LEDMatrix_GFX_Demos that referenced this issue May 9, 2023
@marcmerlin
converted to neomatrix_config.h
3c24408 
Fixes StefanPetrick/FunkyClouds#2

1) remove FastLED.h included by neomatrix_config.h
2) FLOAT.h is unused
3) all functions used must be declared before being used
4) remove FASTLED definitions since they get done in neomatrix_config.h
5) matrix->show() to do the right thing on each backend
6) leds[XV(x,y)] can be replaced by matrix->drawPixel
marcmerlin added a commit to marcmerlin/ArduinoOnPc-FastLED-GFX-LEDMatrix that referenced this issue May 9, 2023
@marcmerlin
Added linux demo for PolarBasics + binary.
4c89452 
Add linux binary example for StefanPetrick/FunkyClouds#2
@marcmerlin
Copy link
Author

you probably check all your gist code in a repo so that it can get patches and bugs, so sorry for mis-using this other project for that :)
If you have linux, you can check https://github.com/marcmerlin/ArduinoOnPc-FastLED-GFX-LEDMatrix/blob/4c89452e070ea9e7c2e9bc4b483986b036f17255/examples/PolarBasics/PolarBasics
I made a precompiled linux binary of your code.
There may be something wrong as it is not cycling through different visuals, and it's not meant to work on an rectangular array, but I'll let you play with it :)

@marcmerlin
Copy link
Author

Were you able to have a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marcmerlin